search

mozilla-mobile / firefox-ios

Firefox for iOS
Mozilla Public License 2.0
12.14k stars 2.91k forks source link

[Landscape] The private tab tray icon mask is missing when rotating the device in landscape #21394

Open abodea opened 1 month ago

abodea commented 1 month ago

Prerequisite

After the fresh install add Firefox to the background and then resume it.

Steps to reproduce

  1. Fresh install FF.
  2. Add ff to the background.
  3. Resume Firefox.
  4. Open a webpage in private browsing (the PB icon is correctly displayed).
  5. Rotate the device in landscape mode.

    Expected behavior

    The PB icon should also be displayed in landscape mode.

    Actual behavior

    The private tab tray icon mask is missing when rotating the device in landscape.

    Device & build information

    • Device: iPhone 15 Pro (17.5.1).
    • Build version: 129 (44092)
    • First seen version: 129 (44023)

      Notes

      Please note that this is not happening on a fresh install, in order to reproduce this it requires at least on restart of the app. Attachments:

https://github.com/user-attachments/assets/4b87f513-4e44-419f-ab0e-9da29c30474d

┆Issue is synchronized with this Jira Task

adudenamedruby commented 1 month ago

bah! I can't reproduce this one either. Is this 100% reproducible for you? I fresh installed, opened, went to a site, force closed, reopened, go to site, background, reopened, open tab in private (mask in there), go to site, go to landscape, and the mask is still there. Am I doing something wrong?

adudenamedruby commented 1 month ago

I've tried to repro on Fennec, on Firefox Beta 129 (44092), on Firefox 129 (44092), and on nightly 44111, and I can't.

adudenamedruby commented 1 month ago

Ok. Now I can reproduce. THe steps are not complete.

data-sync-user commented 1 month ago

➤ Norberto Andres Furlan commented:

Alina Moldovan have you tried this on iPad? Is there any problem there too?

data-sync-user commented 1 month ago

➤ Norberto Andres Furlan commented:

I won’t consider this one a blocker.

data-sync-user commented 1 month ago

➤ Alina Moldovan commented:

Norberto Andres Furlan this is not applicable on iPad. The mask icon was never displayed over the tab tray icon on iPads. The design is a bit different on iPad.

iPad:

!image-20240802-084905.png|width=627,height=160,alt="image-20240802-084905.png"!

iPhone without bug:

!image-20240802-085042.png|width=1769,height=312,alt="image-20240802-085042.png"!

iPhone with bug:

!image-20240802-085126.png|width=1783,height=289,alt="image-20240802-085126.png"!

data-sync-user commented 3 days ago

➤ Alexandru Farcasanu commented:

Did many investigations here… I can’t even reproduce this issue too.