search

mozilla-mobile / firefox-ios

Firefox for iOS
Mozilla Public License 2.0
12.14k stars 2.91k forks source link

Resolve flakey tests for PasswordManagerViewModelTests #21437

Open data-sync-user opened 1 month ago

data-sync-user commented 1 month ago

Look into why this test is flakey

|----| |testQueryLogins()|

┆Issue is synchronized with this Jira Task

data-sync-user commented 1 month ago

➤ Cyndi Chin commented:

PR has been merged, will keep monitoring if this test is still appearing after this change.

data-sync-user commented 1 month ago

➤ Cyndi Chin commented:

The updated tests are still failing. testQueryLoginsWithNumericString testQueryLoginsWithExampleString

data-sync-user commented 1 month ago

➤ Cyndi Chin commented:

https://app.bitrise.io/build/b67e0324-10d7-42a8-b2a0-7e0c51e62637 ( https://app.bitrise.io/build/b67e0324-10d7-42a8-b2a0-7e0c51e62637 )

data-sync-user commented 1 month ago

➤ Cyndi Chin commented:

Refactor these tests to only check for call backs and not DB. Need QA to validate and test login in code for the changes.

data-sync-user commented 1 month ago

➤ Cyndi Chin commented:

As of 8/15, I have not seen any occurrence of this test since merging the PR. Will re-open if I see the issue again.

data-sync-user commented 3 weeks ago

➤ Cyndi Chin commented:

For QA, please test the password manager area. nothing should be affected by the change of modifying the initializer.

data-sync-user commented 3 weeks ago

➤ Diana Andreea Barladeanu commented:

Validated on v130 (44501), with iPhone 15 (17.5).