Improve previous bugfix to improve duplicate network requests to getting favicon URLs and images

mozilla-mobile / firefox-ios

Firefox for iOS

Mozilla Public License 2.0

12.21k stars 2.93k forks source link

Improve previous bugfix to improve duplicate network requests to getting favicon URLs and images #21586

Open data-sync-user opened 2 months ago

data-sync-user commented 2 months ago

Revise the stopgap fix for https://mozilla-hub.atlassian.net/browse/FXIOS-9427 (PR https://github.com/mozilla-mobile/firefox-ios/pull/20991 ).

The current solution does not prevent duplicate favicon requests when the top site cells are reloaded multiple times on the Home tab due to the current architecture of the SiteImageView and related favicon/hero image classes.

┆Issue is synchronized with this Jira Bug

data-sync-user commented 2 months ago

➤ ih-codes commented:

QA Testing Note:

As with https://mozilla-hub.atlassian.net/browse/FXIOS-9427 ( https://mozilla-hub.atlassian.net/browse/FXIOS-9427|smart-link ) , there are no significant user-facing changes here, though regression testing around favicons would be helpful to make sure that there were no side-effects of this change.

data-sync-user commented 1 month ago

➤ Diana Andreea Barladeanu commented:

Validated on v131 (45403), with iPhone 15 (17.5).