mozilla-mobile / firefox-ios

Firefox for iOS
Mozilla Public License 2.0
12.23k stars 2.94k forks source link

[Tab tray refactor] Incorrect display of tab tray icon after a specific scenario #21597

Open DianaABarladeanu opened 2 months ago

DianaABarladeanu commented 2 months ago

Steps to reproduce

  1. Fresh install FF, open several tabs in normal browsing.
  2. Open several tabs in private mode after disabling "close private tabs" toggle.
  3. Return to normal tabs tray and close all by tapping the trashcan button.
  4. Observe the tab tray icon.

Expected behavior The normal tabs are closed, normal browsing homepage is displayed and tab tray icon shows "1", with NO private browsing mask.

Actual behavior Normal browsing homepage is displayed, tab tray icon shows "1", WITH private browsing mask.

Device & build information

Notes

! When closing only one normal tab in tab tray and tapping on "done", the last opened private tab is displayed. !The behavior presented above only reproduces when closing all normal tabs at once --> only in this case you are directed to normal browsing homepage although you've last visited a website in private browsing.

This issue is not reproducible without tab tray refactor.

Attachments:

https://github.com/user-attachments/assets/bbf39d67-083c-4721-9c8e-bef5fcf58788

┆Issue is synchronized with this Jira Task

data-sync-user commented 2 months ago

➤ Diana Andreea Barladeanu commented:

Norberto Andres Furlan , please revise the behavior detailed in notes. Thanks!