search

mozilla-mobile / firefox-ios

Firefox for iOS
Mozilla Public License 2.0
12.24k stars 2.94k forks source link

Flaky test test_didTapMainButton_withSaveState_callsAddCreditCard() #21636

Open data-sync-user opened 2 months ago

data-sync-user commented 2 months ago

This test is flaky in CreditCardBottomSheetViewModelTests

┆Issue is synchronized with this Jira Task

data-sync-user commented 2 months ago

➤ Cyndi Chin commented:

Phase I: Add more checks to determine if Bitrise error is not nil error Phase II: Make optional and guard Phase III: Instantiate locally within the tests

data-sync-user commented 2 months ago

➤ Cyndi Chin commented:

Decided to disable this test to see if crash occurs in other tests. On 9/16, we are now seeing crashes on new tests CreditCardInputViewModelTests . My inclination is to disable CredentialAutofillCoordinatorTests since they have tab related code.

data-sync-user commented 2 months ago

➤ Cyndi Chin commented:

Monitoring for a few days, no additional crashes yet, will continue to keep an eye out during the week.

data-sync-user commented 1 month ago

➤ Cyndi Chin commented:

Going to add back the CreditCard tests since it seems CredentialAutofillCoordinator was the culprit

data-sync-user commented 1 month ago

➤ Cyndi Chin commented:

Added back Credit Card Bottom Sheet tests

data-sync-user commented 6 days ago

➤ Cyndi Chin commented:

Assigning to Nish as I will be OOO, these are the flakey credit card tests that keeps crashing.