search

mozilla-mobile / firefox-ios

Firefox for iOS
Mozilla Public License 2.0
12.15k stars 2.91k forks source link

Pop-up window crashes app #21658

Open clarmso opened 1 month ago

clarmso commented 1 month ago

Steps to reproduce

  1. Open a (test) website that contains a pop-up window. (Example: https://www.webroot.com/services/popuptester1.htm)
  2. Tap hamburger menu and open Settings.
  3. Turn off "Block Pop-up Windows".
  4. Tap "Done" to close the Settings.
  5. Open a (test) website that contains a pop-up window. (Example: https://www.webroot.com/services/popuptester1.htm)

Automated test: XCUITests/NavigationTest/testWriteToChildPopupTab The test fixture used in the automated test: https://github.com/mozilla-mobile/firefox-ios/blob/main/test-fixtures/test-window-opener.html

Expected behavior

The pop-up window is shown in the last step

Actual behavior

The app crashes in the last step.

Device & build information

https://github.com/user-attachments/assets/b1c10d56-1227-4814-8253-1353a8066315

┆Issue is synchronized with this Jira Task

abodea commented 1 month ago

Hello, @clarmso please note that we are not able to reproduce this issue: On the website example you posted, I don't think anything is happening as it looks broken for example when you attempt to "test" any pop-up it only redirects you to a blank page (I tried this on a desktop website to see how the website is). We tried on the following devices on v130 (44595):

data-sync-user commented 1 month ago

➤ Clare So commented:

Andrei Bodea I have attached the recording to the Jira ticket.

clarmso commented 1 month ago

I confirmed that the PR https://github.com/mozilla-mobile/firefox-ios/commit/1a53ed9dd0cc3a41cc63786bbc6ee6f3667dfa48 from Aug 26 started the regression.

v130 is not affected.

data-sync-user commented 1 month ago

➤ Andrei Bodea commented:

Thank you I was able to reproduce it on v9000 (44662) with iPhone 13 Pro (15.7.1). Also, thx I can see now the video on Jira, I was checking GitHub.

data-sync-user commented 1 month ago

➤ Nishant Bhasin commented:

Norberto Andres Furlan We should fix this, likely to be added to top of backlog for next grooming

nbhasin2 commented 4 weeks ago

Alex is already assigned to this, should be fixed soon 🤞🏼

data-sync-user commented 3 weeks ago

➤ Alexandru Farcasanu commented:

Nishant Bhasin Yesterday I was able to reproduce the issue but now is no more reproducible on main. After did some checks, Matt Reagan fixed this https://mozilla-hub.atlassian.net/browse/FXIOS-9921 ( https://mozilla-hub.atlassian.net/browse/FXIOS-9921|smart-link ) and merged it. Also, Matt’s fix fixed also this issue. (after investigations). Moving it to the QA.

data-sync-user commented 1 week ago

➤ Andrei Bodea commented:

Verified as fixed on v131 (45514) with iPhone 15 Pro (17.5). Please note that the issue cannot be reproduced anymore, FF does not crash but there is a regression as an About:blank tab/page is opened instead of crashing now. https://github.com/mozilla-mobile/firefox-ios/issues/22139 ( https://github.com/mozilla-mobile/firefox-ios/issues/22139|smart-link ) added this as a regression.