Generate an "H" letter for internal URL favicons (e.g. Home in Inactive Tabs) and skip URL requests to find favicon

mozilla-mobile / firefox-ios

Firefox for iOS

Mozilla Public License 2.0

12.23k stars 2.94k forks source link

Generate an "H" letter for internal URL favicons (e.g. Home in Inactive Tabs) and skip URL requests to find favicon #21687

Open data-sync-user opened 2 months ago

data-sync-user commented 2 months ago

┆Issue is synchronized with this Jira Task

data-sync-user commented 2 months ago

➤ ih-codes commented:

Testing Hint for QA:

You can see an example of a favicon for an internal URL (e.g. a Home screen tab) if you use the hidden debug settings, turn on “Set Inactive Tab Timeout to 10s”, and then wait for a Home tab to appear in the Tab Tray’s “Inactive Tabs” section at the top.

Once the Home tab is in there, open the Inactive Tabs and view the favicon. It should now be “H” for “Homepage”.

data-sync-user commented 1 month ago

➤ Diana Andreea Barladeanu commented:

Validated on v131 (45514), with iPhone 15 (17.5). Bug ticket logged here ( https://github.com/mozilla-mobile/firefox-ios/issues/22032 ).