Wrong FxA WebChannel message parsed for account deletion - Githubissues

mozilla-mobile / firefox-ios

Firefox for iOS

Mozilla Public License 2.0

12.21k stars 2.93k forks source link

Wrong FxA WebChannel message parsed for account deletion #21814

Closed jonalmeida closed 1 month ago

jonalmeida commented 1 month ago

Steps to reproduce

Go to Settings > Manage Account
Delete the account.
Observe.

Expected behaviour

The web channel message fxaccounts:delete is correctly parsed.
The UI affordance for Manage Account is dismissed.

Actual behaviour

The web channel message we look for is incorrect: fxaccounts:delete_account.
The UI affordance is not dismissed.

Device & build information

Device: All
Build version: All
First seen version: Beginning of time.

Notes

FxA command string: https://github.com/mozilla/fxa/blob/788bf5b51485f345d96267888a931011d8843e78/packages/fxa-settings/src/lib/channels/firefox.ts#L6 Desktop for reference: https://searchfox.org/mozilla-central/rev/f09e3f9603a08b5b51bf504846091579bc2ff531/services/fxaccounts/FxAccountsCommon.sys.mjs#142

┆Issue is synchronized with this Jira Task

jonalmeida commented 1 month ago

Will fix this tomorrow.

jonalmeida commented 1 month ago

Without fixing this it displays to the user that they are still signed in and clicking Manage Account will then display this page error: