search

mozilla-mobile / firefox-ios

Firefox for iOS
Mozilla Public License 2.0
12.23k stars 2.93k forks source link

Tracking Protection add missing borders for views #21825

Open data-sync-user opened 2 months ago

data-sync-user commented 2 months ago

┆Issue is synchronized with this Jira Bug

data-sync-user commented 1 month ago

➤ ih-codes commented:

Note: Adding borders to table view sections is a larger development issue that is affecting several new areas of the app (we do it for accessibility reasons).

Slack discussion: https://mozilla.slack.com/archives/C05C9RET70F/p1727114877800269 ( https://mozilla.slack.com/archives/C05C9RET70F/p1727114877800269|smart-link )

This ticket is blocked until we arrive at a solution to use across the whole app.

data-sync-user commented 1 month ago

➤ Alexandru Farcasanu commented:

Moving back to TODO until this ticket will be unblocked.

data-sync-user commented 3 weeks ago

➤ Nishant Bhasin commented:

cc ih-codes do we need this or are we going with no borders?

data-sync-user commented 3 weeks ago

➤ ih-codes commented:

Yes they are neededNishant Bhasin (eventually, but not right now). Orla suggested we can implement without the borders for now and then add them later.

More background: There will have to be a conversation later with Orla where a few of us meet and decide on a common solution for the borders. This issue exists with the Tracking Protection, new Menu, new Settings, etc. and is not a straightforward UI implementation as far as we can tell.