mozilla-mobile / firefox-ios

Firefox for iOS
Mozilla Public License 2.0
12.22k stars 2.93k forks source link

[Tab tray refactor] [Inactive tabs] - Inactive tabs are closed by tapping on the active tab #21860

Open DianaABarladeanu opened 1 month ago

DianaABarladeanu commented 1 month ago

Prerequisites Set inactive tab timeout to 10 sec from secret settings.

Steps to reproduce

  1. Have several inactive tabs and the inactive tabs panel expanded.
  2. Have one active tab.
  3. Tap on the "x" button of the active tab.
  4. Observe.

Expected behavior The active tab is closed.

Actual behavior After the real active tab is closed, it is replaced by the inactive ones, one by one. By tapping on the "active" tab, you are in fact closing the inactive ones.

Device & build information

Notes Attachments:

https://github.com/user-attachments/assets/bac77bfe-7718-4b52-80f7-021d9ab33755

┆Issue is synchronized with this Jira Task

data-sync-user commented 1 month ago

➤ Andrei Bodea commented:

Verified as fixed on v9000 (45230) with iPhone 15 Pro (17.5.1) and iPhone 15 (17.5).

Norberto Andres Furlan ih-codes I think if this bug was fixed it should have the QA Needed Status.

data-sync-user commented 1 month ago

➤ ih-codes commented:

Andrei Bodea Sorry about that, I fixed a bunch of tickets with one PR and must’ve missed this one. I’ll assign it to me.

I’ve changed the status to “QA verified” since you’ve checked it, I hope that’s okay.

data-sync-user commented 1 month ago

➤ Andrei Bodea commented:

Hello, ih-codesplease note the following: This issue was verified only on v9000 (v9000 in TF = Nightly latest build from master). When we verify the issues on v9000 means they are not yet into the beta cycle in our case 131, so here is the status QA Verified on the Jira means the ticket is closed, the reason it was still with QA Needed is that we let it like this until this bug will be merged into an official and possible Release Candidate, when we are able to double check it in v131 or the beta builds then we will change the status to the ticket in this case to QA Verified so I will change it back until we can make sure it's working well on an official build in our case 131.

data-sync-user commented 1 month ago

➤ ih-codes commented:

Ahh I understand! Thank you Andrei Bodea for explaining that to me! Much appreciated. 🙏

data-sync-user commented 1 month ago

➤ Diana Andreea Barladeanu commented:

Verified as fixed on v9000 (45732), with iPhone 15 (17.5).

data-sync-user commented 1 month ago

➤ Diana Andreea Barladeanu commented:

Verified as fixed on v131(45711), with iPhone 15 (17.5).