mozilla-mobile / firefox-ios

Firefox for iOS
Mozilla Public License 2.0
12.2k stars 2.92k forks source link

[Tab tray refactor] [Inactive tabs] - Webpage displayed as inactive and active tab at the same time #21863

Open DianaABarladeanu opened 1 month ago

DianaABarladeanu commented 1 month ago

Prerequisites Set inactive tab timeout to 10 sec from secret settings.

Steps to reproduce

  1. Have several inactive tabs.
  2. Open 2 or more new other tabs.
  3. Tap on close all inactive tabs.
  4. Tap on undo.
  5. Repeat steps 3 and 4 several times.
  6. Observe.

Expected behavior The inactive tabs are correctly restored. The active tabs are correctly displayed.

Actual behavior After repeatedly closing and undo-ing, some tabs are displayed both as inactive and active tabs.

Device & build information

Notes Attachments: Please observe the "pwning.genius" link: https://github.com/user-attachments/assets/094cdfbe-ee30-4ded-a949-b24300d9f2e0

┆Issue is synchronized with this Jira Task

data-sync-user commented 1 month ago

➤ ih-codes commented:

Norberto Andres Furlan I’m pretty sure this is happening more often as a consequence of the debug 10s timeout when testing inactive tabs. 🤔

I suspect the issue is that the bottom part of the tab tray doesn’t refresh after an active tab becomes inactive. In the real app, this is a 14 day time so it’s unlikely the user notices the issue.

data-sync-user commented 3 weeks ago

➤ Alina Moldovan commented:

This issue still reproduces: using v9000 (45624) and iPhone 14+ (16.0.3)

!image-20240925-113534.png|width=25%,alt="image-20240925-113534.png"!

data-sync-user commented 3 weeks ago

➤ Diana Andreea Barladeanu commented:

The issue is still reproducible on v9000 (45732), with iPhone 15 (17.5).