search

mozilla-mobile / firefox-ios

Firefox for iOS
Mozilla Public License 2.0
12.18k stars 2.92k forks source link

Investigate whether it is possible to add Sentry errors to catch wrongly disabled UI buttons #21908

Open data-sync-user opened 1 month ago

data-sync-user commented 1 month ago

This is a task that arose out of the incident iOS Back Button Disabled Intermittently. This bug was caught due to us seeing a user review on the app store that reported it, so we wanted to investigate adding a sentry error so that we wouldn’t have to rely on User Reports in the future.

┆Issue is synchronized with this Jira Task

data-sync-user commented 1 month ago

➤ Matt Reagan commented:

Note: I believe this will probably be difficult to log or track with sentry events, the reason being that the same logic that evaluates whether the navigation buttons should be enabled would be the logic we rely upon for the events, so if a bug is introduced that breaks that logic, the sentry events will be just as blind as the code for the UI itself.

It would probably be good to dig into this a bit further regardless to see if there is a reliable way we could catch this type of bug if it ever makes it into the builds again.