mozilla-mobile / firefox-ios

Firefox for iOS
Mozilla Public License 2.0
12.22k stars 2.93k forks source link

[Favicons refactor] - "Bestbuy" favicon is blurred #21928

Open DianaABarladeanu opened 1 month ago

DianaABarladeanu commented 1 month ago

Steps to reproduce

  1. Fresh install FF.
  2. Access bestbuy.com.
  3. Save it to shortcuts.
  4. Add it to bookmarks.
  5. Make sure to see it in the jump back in section.
  6. Set inactive tabs timeout to 10 sec from secret settings so that the website is also present there.
  7. Observe the favicon display in all the sections mentioned above.

Expected behavior The favicon is clearly displayed in all the sections mentioned above.

Actual behavior The favicon is blurred in all of the sections above.

Device & build information

Notes

Same issue reproduces on the following websites: bing.com

Attachments: Skype_Picture_2024_09_12T15_01_20_045Z ImportedPhoto 747846329 885062 ImportedPhoto 747846329 883848

photo-collage png (2)

┆Issue is synchronized with this Jira Task

data-sync-user commented 1 month ago

➤ Norberto Andres Furlan commented:

ih-codes can you take a look to this one? THanks!

data-sync-user commented 1 month ago

➤ ih-codes commented:

Norberto Andres Furlan Just looking at the Bestbuy website (select country page), it’s clear they only have a low quality favicon:

Link: https://www.bestbuy.com/~assets/bby/_com/header-footer/images/favicon-32.png ( https://www.bestbuy.com/~assets/bby/_com/header-footer/images/favicon-32.png )

So in this case, the blurriness is expected. Even the main website doesn’t have a better quality one, or even any Open Graph image metadata.

Only bundling a higher quality version of the favicon ourselves could improve this situation, which I think we want to avoid for now. So I assume this is just one of those websites we let be blurry.

data-sync-user commented 1 month ago

➤ Diana Andreea Barladeanu commented:

Hi ih-codes Norberto Andres Furlan ! So we should ignore this grade of bluriness in the future and only log the awfully blurred favicons?

data-sync-user commented 1 month ago

➤ ih-codes commented:

I think that’s appropriate, but I’ll defer to Norberto Andres Furlan