mozilla-mobile / firefox-ios

Firefox for iOS
Mozilla Public License 2.0
12.2k stars 2.92k forks source link

[Tab tray refactor][Inactive Tabs] Firefox crashes when deleting and the undo the inactive tabs multiple times in a row #21953

Open abodea opened 1 month ago

abodea commented 1 month ago

Prerequisites Set inactive tab timeout to 10 sec from secret settings.

Steps to reproduce

  1. Have several inactive tabs and the inactive tabs panel expanded.
  2. Close all the inactive tabs.
  3. Undo the recently closed inactive tabs.
  4. Repeat the steps 2-3 few times in a row.

    Expected behavior

    The inactive tabs should be restored without issues.

    Actual behavior

    Firefox crashes when deleting and the undo the inactive tabs multiple times in a row

    Device & build information

    • Device: iPhone 15 Pro (17.5)
    • Build version: v9000 (45230)
    • First seen version: v9000 (45230)

      Notes

      Please note that I was able to reproduce this issue only once in 10 tries. Attachments:

Crash_log.zip

┆Issue is synchronized with this Jira Task

ih-codes commented 1 month ago

Thank you for attaching the crash log @abodea, that gives me a good idea where to look considering this is hard to reproduce. 🙏

data-sync-user commented 3 weeks ago

➤ Alina Moldovan commented:

I managed to reproduce this issue once using v9000 (45624) and iPhone 15+ (18.0) Please see the attached logs

[^Client-2024-09-25-150015.ips]

data-sync-user commented 3 weeks ago

➤ Alina Moldovan commented:

Not able to reproduce this issue anymore using v9000 (45732) and iPhone 15 Pro (17.5) iPhone 14+ (16.0.3) iPhone 15+ (18.0) iPad Air 13-inch - M2 (17.4)

data-sync-user commented 3 weeks ago

➤ Andrei Bodea commented:

Verified as fixed on v131 (45771) with iPhone 14 (17.4.1), iPhone 15 Pro (17.5), and iPhone 15 (17.5).