search

mozilla-mobile / firefox-ios

Firefox for iOS
Mozilla Public License 2.0
12.22k stars 2.93k forks source link

[Tab tray refactor] [Inactive tabs] - Incorrect behavior when closing an active tab [Intermittent] #21954

Open DianaABarladeanu opened 1 month ago

DianaABarladeanu commented 1 month ago

Prerequisites Set inactive tab timeout to 10 sec from secret settings.

Steps to reproduce

  1. Have several inactive tabs.
  2. Open several new websites.
  3. Start closing the active tabs by tapping randomly on the "x' button.
  4. Observe.

Expected behavior Each active tab closes correctly.

Actual behavior In some cases, tapping on "x" button on one of the tabs, closes another one too or even all of the active tabs.

Device & build information

Attachments:

https://github.com/user-attachments/assets/b66f18af-1230-4254-a97d-0dd1ac4d6935

┆Issue is synchronized with this Jira Task

data-sync-user commented 1 month ago

➤ ih-codes commented:

Pretty sure this is the same issue as https://mozilla-hub.atlassian.net/browse/FXIOS-9954 ( https://mozilla-hub.atlassian.net/browse/FXIOS-9954|smart-link ) , which is made worse by having very small 10 second testing windows for inactive tabs. Basically the inactive and active parts of the tab tray are not refreshed in sync, causing some funny UI issues.

Here, it looks to me like the Amazon tab is created, and about 10s later based on the video time, it’s getting moved into inactive tabs.

My guess is that two tabs did not disappear at the same time, but actually the Amazon tab got moved to inactive tabs instead.

Diana Andreea Barladeanu Would you be able to confirm that this is the case? Thank you!

data-sync-user commented 1 month ago

➤ Diana Andreea Barladeanu commented:

ih-codes From what I see, by tapping on the active tab, the inactive links are transferred one by one in the respective tab and they are both inactive and active at the same time, before being closed with the “x” button.

So it’s indeed similar with https://mozilla-hub.atlassian.net/browse/FXIOS-9954 ( https://mozilla-hub.atlassian.net/browse/FXIOS-9954|smart-link ) .

DianaABarladeanu commented 1 month ago

The issue is still reproducible on v9000 (45624), with iPhone 15 (17.5).

data-sync-user commented 1 month ago

➤ Diana Andreea Barladeanu commented:

The issue is still reproducible on v9000 (45732), with iPhone 15 (17.5).