search

mozilla-mobile / firefox-ios

Firefox for iOS
Mozilla Public License 2.0
12.15k stars 2.91k forks source link

Incorrect tab count in toolbar after inactive tabs are closed and restored with Undo #21972

Open data-sync-user opened 2 weeks ago

data-sync-user commented 2 weeks ago

Open multiple inactive tabs.

Open tab tray, expand inactive tabs, close all tabs with button.

Tap “Undo” in the toast to restore all these inactive tabs.

Close the tab tray.

The toolbar now displays the incorrect count of tabs, not taking into account the restored inactive tabs.

This corrects itself after selecting a new tab.

!incorrect toolbar count after closing and restoring inactive tabs.mp4|width=1178,height=2556,alt="incorrect toolbar count after closing and restoring inactive tabs.mp4"!

┆Issue is synchronized with this Jira Bug

data-sync-user commented 3 days ago

➤ Cyndi Chin commented:

Also came across this issue, toggling the inactive tabs to be OFF fixes the count issue in the tab tray, but the toolbar becomes in consistent. If the count in both places should always be the same, then ideally the come from the same data source as well.

data-sync-user commented 2 days ago

➤ ih-codes commented:

Note: I believe this is a redux refresh action issue. Something needs to fire after undoing the inactive tabs closure which will refresh the count correctly in the toolbar.