mozilla-mobile / firefox-ios

Firefox for iOS
Mozilla Public License 2.0
12.2k stars 2.92k forks source link

[Favicons refactor] - Loading delay with share menu #22082

Open DianaABarladeanu opened 1 month ago

DianaABarladeanu commented 1 month ago

Steps to reproduce

  1. Install FF.
  2. Make sure you have some saved bookmarks.
  3. Open share menu (either with hamburger menu or with context menu )on shortcuts, bookmarks, pocket articles, jump back in links etc.
  4. Observe the favicons.

Expected behavior The favicons are instantly loaded.

Actual behavior There is a delay in loading the favicons. A compass is displayed for a couple of seconds.

Device & build information

Notes Attachments:

https://github.com/user-attachments/assets/0e0f91a4-3e81-4db8-8108-67f6d835f92d

┆Issue is synchronized with this Jira Task

nbhasin2 commented 1 month ago

Hi @DianaABarladeanu could we also check the following

menu

long press

It has come to my attention that favicons delay might cause delay in share sheet loading so want to ensure its working as intended for both current app version in production and also in Nightly

Thanks!

DianaABarladeanu commented 3 weeks ago

We didn't notice a delay in loading the share sheet, it seems to function as before the favicon refactor.