search

mozilla-mobile / firefox-ios

Firefox for iOS
Mozilla Public License 2.0
12.2k stars 2.92k forks source link

[Favicons refactor] - The favicons load with a delay in context menu #22083

Open DianaABarladeanu opened 1 month ago

DianaABarladeanu commented 1 month ago

Steps to reproduce

  1. Install FF.
  2. Long tap on different links (from shortcuts, from bookmarks, jump back in, pocket etc) in order to open context menu.
  3. Observe the favicons.

Expected behavior The favicons are instantly loaded.

Actual behavior There is a delay in loading the favicons when first opening context menu.

Device & build information

Notes Attachments:

https://github.com/user-attachments/assets/98199166-3495-4cf8-8df9-ef6e6ccdf328

┆Issue is synchronized with this Jira Task

nbhasin2 commented 4 weeks ago

Seems like a cache isn't there and its fetching icons

nbhasin2 commented 4 weeks ago

Related to https://github.com/mozilla-mobile/firefox-ios/issues/22123

nbhasin2 commented 4 weeks ago

There should be a placeholder (Globe icon there) and then it should fetch. If fetch fails then we can go back to either letter icon or globe

nbhasin2 commented 4 weeks ago

Dupes: https://github.com/mozilla-mobile/firefox-ios/issues/22082