mozilla-mobile / firefox-ios

Firefox for iOS
Mozilla Public License 2.0
12.24k stars 2.94k forks source link

Display Alternative Search Engine Suggestions + Firefox Suggest after the users selected a new engine #22222

Open data-sync-user opened 1 month ago

data-sync-user commented 1 month ago

┆Issue is synchronized with this Jira Spike

data-sync-user commented 1 month ago

➤ ih-codes commented:

Findings:This will add additional work to the project, but it doesn’t look like it’ll be too much!

Currently there’s a mechanism to change the UI and update the search engine suggestions results for a new default engine, which I might be able to leverage. However, it is using NSNotification, which is less than ideal. I’d like to refactor the relevant code paths if there’s time.

data-sync-user commented 1 month ago

➤ ih-codes commented:

Michael Verdi Could you provide a little more information on this bullet point for me in terms of Phase 1?

{quote}* If the user deletes the search, everything goes back to the default again.{quote}

I know we want to revert to the default engine if a search is performed. But do we also also want to revert if the user simply clears their current search query by backspacing a bunch on their keyboard? Because in that case, I assume they want to simply make a new search query, not necessarily change their engine.

On the other hand, if the user taps the little clear button (the ❎ on the right hand side of the text field), then I think there's a better argument for reverting to the default engine again. 🤔

!Screenshot 2024-10-01 at 2.33.07 PM.png|width=883,height=101,alt="Screenshot 2024-10-01 at 2.33.07 PM.png"!

Anyway, I just want to make sure I’m understanding the interactions correctly here. Thanks! 🙏

data-sync-user commented 1 month ago

➤ ih-codes commented:

Discussed at meeting, we only revert search after a completed search has been done. Not on backspace or clear of the text field.