search

mozilla-mobile / firefox-ios

Firefox for iOS
Mozilla Public License 2.0
12.22k stars 2.93k forks source link

Delay on pin/unpin websites #22323

Open dragosb01 opened 1 month ago

dragosb01 commented 1 month ago

Steps to reproduce

  1. Open a website
  2. Tap on the hamburger menu and add it to shortcuts
  3. Go to homepage and notice the pin icon next to the website name
  4. Long press the website to open the context menu and tap on unpin

    Expected behavior

    The website should be unpined instantly

    Actual behavior

    It takes about 5 seconds for the website to be unpined. Notice the pin/unpin icon - how long it takes for it to appear/dissapear. See attached video.

    Device & build information

https://github.com/user-attachments/assets/c517bdc7-4108-4889-9769-792b7515bee9

┆Issue is synchronized with this Jira Task

clarmso commented 3 weeks ago

@dragosb01 Could you reproduce the issue manually as well?

dragosb01 commented 3 weeks ago

testPinToShortcuts

Yes, it can be reproduced manually as well.

data-sync-user commented 2 weeks ago

➤ Alexandru Farcasanu commented:

Dragos Bigu Norberto Andres Furlan

After investigations: this issue is impacted by a refactor from this PR ( https://github.com/mozilla-mobile/firefox-ios/pull/21480 ). Since this issue appear only on simulators (with the mention that I have tested only on one real device iPhone 12 Pro iOS 16.1) and after a discussion with Orla Mitchell, this issue should be moved back to the backlog for now.

data-sync-user commented 2 weeks ago

➤ Dragos Bigu commented:

Because this issue is still reproducing and cannot be closed i am proposing to be left in to do status with a low priority.

hemche commented 2 weeks ago

Tested on iPhone 15 pro - iOS 18.1. real device. No delay seen✅

https://github.com/user-attachments/assets/49412e34-85cd-4f32-81fd-d928191f1026