Incorrect connection type is displayed in the ETP panel

mozilla-mobile / firefox-ios

Firefox for iOS

Mozilla Public License 2.0

12.2k stars 2.92k forks source link

Incorrect connection type is displayed in the ETP panel #22581

Open alinamoldovan84 opened 3 days ago

alinamoldovan84 commented 3 days ago

Steps to reproduce

Open a secure page (bbc.com, google.com).
Tap on the "ETP lock" icon from the URL toolbar.
Check the connection type

Expected behavior

The connection type should match the connection type displayed in the addessbar

Actual behavior

Always "Connection is not secure" is displayed together with the insecure connection icon

Device & build information

Device: iPhone 14 Pro Max (iOS 16.2), iPhone 14+ (16.0.3), iPad Pro 4th Gen (18.0)
Build version: v9000 (46466)
First seen version: ?
Notes

Attachments:

┆Issue is synchronized with this Jira Task

PARAIPAN9 commented 3 days ago

I see that getpocket.com is using an https connection which makes the site secure, meaning that the toolbar lock icon behaves ok. It is more like a TP problem.

data-sync-user commented 2 days ago

➤ Norberto Andres Furlan commented:

What means a TP Problem?

data-sync-user commented 2 days ago

➤ Winnie Teichmann commented:

Norberto Andres Furlan this has to be fixed in the Tracking Protection view and not in toolbar.

mattreaganmozilla commented 2 days ago

Note: there was a recent fix that changed the ETP panel's isConnectionSecure to match whatever the lock icon is showing, which was intended to fix this exact problem. Do we know if this was tested with the most recent build? (I'm not actually sure, at this point, how it's possible for the ETP panel to show a different SSL status than the lock icon)