search

mozilla-mobile / firefox-ios

Firefox for iOS
Mozilla Public License 2.0
12.21k stars 2.93k forks source link

The app crashes when switching active tabs, while also having inactive tabs #22582

Open DianaABarladeanu opened 3 weeks ago

DianaABarladeanu commented 3 weeks ago

Steps to reproduce

  1. Install Firefox.
  2. Set the inactive tabs timeout to 10 seconds from the secret settings.
  3. Open several websites to populate the inactive tabs section.
  4. Open some new tabs.
  5. Try to switch positions of the active tabs.
  6. Observe.

Expected behavior The tabs are correctly switched.

Actual behavior The app crashes.

Device & build information

Notes Attachments:

https://github.com/user-attachments/assets/e7cdab71-2a38-4672-8bd7-079ab1c6e016

Client-2024-10-16-154044.ips.zip

┆Issue is synchronized with this Jira Task

data-sync-user commented 2 weeks ago

➤ Norberto Andres Furlan commented:

ih-codes added the options to test with more time. (1 min, 2 min). Can you test again? Thanks!

data-sync-user commented 2 weeks ago

➤ Diana Andreea Barladeanu commented:

Norberto Andres Furlan ih-codes The issue is reproducible with the 1 and 2 minutes options, too.

data-sync-user commented 2 weeks ago

➤ ih-codes commented:

My guess is if you have a few inactive tabs and 2 fresh active tabs, with the 2min option, you’ll be able to drag and drop the 2 fresh tabs successfully a few times (at least until they become 2 minutes old…).

I think Sophie Amin is working on a fix in this area right now since I noticed this crash late last Friday when testing one of her unrelated PRs. We had a chat with Orla this week and the decision was to make inactive tabs only get set at app startup instead of on a timer. CC Norberto Andres Furlan