search

mozilla-mobile / firefox-ios

Firefox for iOS
Mozilla Public License 2.0
12.2k stars 2.92k forks source link

Lock icon does not appear on awesome bar for untrusted connection #22600

Open clarmso opened 1 week ago

clarmso commented 1 week ago

Steps to reproduce

  1. Open www.badssl.com
  2. Tap "Expired" under "Certificate".
  3. Wait until the page load.
  4. Look for the lock icon next to the URL.

See XCUITests/TrackingProtectionTests/testLockIconSecureConnection

I can reproduce the issue manually

Expected behavior

On release/v132, the slashed lock icon is present: Simulator Screenshot - iPhone 15 - 2024-10-16 at 15 05 09

Actual behavior

No lock icon is seen: Simulator Screenshot - iPhone 15 - 2024-10-16 at 14 51 08

Device & build information

┆Issue is synchronized with this Jira Task

data-sync-user commented 1 week ago

➤ Norberto Andres Furlan commented:

Alexandru Farcasanu can you check this one? Can it be related to any change on Unified Panel?

data-sync-user commented 1 week ago

➤ Norberto Andres Furlan commented:

Andrei Bodea for visibility.

clarmso commented 1 week ago

I've confirmed that the regression occurs since this PR: https://github.com/mozilla-mobile/firefox-ios/pull/22474. @mattreaganmozilla

mattreaganmozilla commented 1 week ago

I self-assigned this ticket, will take a look as soon as I have a chance. We need to be careful that whatever fix is implemented for this does not regress the security fix added for https://mozilla-hub.atlassian.net/browse/FXIOS-7328.

data-sync-user commented 1 week ago

➤ Andrei Bodea commented:

Thanks, Norberto Andres Furlanwill keep an eye on this.