search

mozilla-mobile / firefox-ios

Firefox for iOS
Mozilla Public License 2.0
12.24k stars 2.94k forks source link

[Toolbar Redesign] New toolbar's < back button is obscured by iPhone's Dynamic Island in the Homepage in landscape orientation #22653

Closed cpeterso closed 2 weeks ago

cpeterso commented 1 month ago

Steps to reproduce

  1. Manually enroll in the iOS New Toolbar experiment on TestFlight.
  2. Rotate your phone to landscape orientation.
  3. Tap the toolbar's + button or address bar to open the Homepage.
  4. Try to exit the Homepage screen.

Expected behavior

The old toolbar has a < back button to exit the Homepage screen:

image

Actual behavior

The new toolbar's < back button to exit the Homepage screen is obscured by my iPhone's Dynamic Island:

image

Device & build information

┆Issue is synchronized with this Jira Task

data-sync-user commented 4 weeks ago

➤ Matt Lichtenstein commented:

Hey Aarjav Pandya, do you have any recommendations here?

data-sync-user commented 3 weeks ago

➤ Aarjav Pandya commented:

Hey Matt, I have updated the padding for the app switcher here ( https://www.figma.com/design/8fsCvtnweBkWGZ9NfL907l/__-Toolbar-Redesign?node-id=26701-237983&t=Ux9GCZ0ujgfnKCn4-4 ).

data-sync-user commented 3 weeks ago

➤ Matt Lichtenstein commented:

Thanks Aarjav Pandya - reassigning to myself

data-sync-user commented 3 weeks ago

➤ Matt Lichtenstein commented:

Aarjav Pandya was this comment meant for https://mozilla-hub.atlassian.net/browse/FXIOS-10337 ( https://mozilla-hub.atlassian.net/browse/FXIOS-10337|smart-link )

data-sync-user commented 3 weeks ago

➤ Aarjav Pandya commented:

You are right, my bad, here are the links for this one. Homepage - https://www.figma.com/design/8fsCvtnweBkWGZ9NfL907l/__-Toolbar-Redesign?node-id=26560-184043&t=Ux9GCZ0ujgfnKCn4-4 ( https://www.figma.com/design/8fsCvtnweBkWGZ9NfL907l/__-Toolbar-Redesign?node-id=26560-184043&t=Ux9GCZ0ujgfnKCn4-4|smart-link ) Webpage - https://www.figma.com/design/8fsCvtnweBkWGZ9NfL907l/__-Toolbar-Redesign?node-id=26560-189817&t=Ux9GCZ0ujgfnKCn4-4 ( https://www.figma.com/design/8fsCvtnweBkWGZ9NfL907l/__-Toolbar-Redesign?node-id=26560-189817&t=Ux9GCZ0ujgfnKCn4-4|smart-link )

data-sync-user commented 3 weeks ago

➤ Matt Lichtenstein commented:

Aarjav Pandya those links point to iPad screenshots, does landscape iPhone follow the same spec?

data-sync-user commented 3 weeks ago

➤ Aarjav Pandya commented:

Yes, iPad should follow the same designs.

data-sync-user commented 2 weeks ago

➤ Andrei Bodea commented:

Verified as fixed on v133 (46984) with iPhone 15 Pro (18.2).