search

mozilla-mobile / firefox-ios

Firefox for iOS
Mozilla Public License 2.0
12.25k stars 2.94k forks source link

Enable Address Autofill Phase 2 by default for Canada and US #22707

Open data-sync-user opened 1 month ago

data-sync-user commented 1 month ago

Enable Address Autofill Phase 2 by default for Canada and US

┆Issue is synchronized with this Jira Task

data-sync-user commented 1 month ago

➤ Andres Furlan commented:

Issam Mani can you take this one? I think we can do it for 132.1

nbhasin2 commented 1 month ago

https://github.com/mozilla-mobile/firefox-ios/blob/main/firefox-ios/Client/Frontend/Autofill/Address/AddressUtility/AddressLocaleFeatureValidator.swift#L7-L14

@issammani should double check what we did here 🤔

data-sync-user commented 1 month ago

➤ Issam Mani commented:

Yes. So what Nish shared enabled phase 1 by default for all CA and US users. We can do the same for phase 2 (we will need to swap this ( https://github.com/mozilla-mobile/firefox-ios/blob/c87c57212acff5cb24fb01b31a16d4340e01dd30/firefox-ios/Client/Frontend/Autofill/Address/AddressListViewModel.swift#L38 ) with the flag Nish shared ). But aren’t we at 40% right now of US and CA users for phase 2 ? I thought we want to go with the experiment until 100% and then enable by default. Maybe I am missing something Andres Furlan

data-sync-user commented 2 weeks ago

➤ Andres Furlan commented:

Issam Mani You are right, I will increase with the Nimbus rollout. Should we enable it by default on 133?

data-sync-user commented 2 weeks ago

➤ Issam Mani commented:

That works. I can open a PR to enable it by default on 133 😄