search

mozilla-mobile / firefox-ios

Firefox for iOS
Mozilla Public License 2.0
12.25k stars 2.95k forks source link

Reader View button crashes the app intermittently #22962

Open clarmso opened 3 weeks ago

clarmso commented 3 weeks ago

Steps to reproduce

Note: The crash may not be reproduced manually or via Xcode IDE. The app crashes when the reader view 📜 button from the awesome bar is tapped.

CLI command:

xcodebuild build-for-testing -target Client -scheme Fennec -destination 'platform=iOS Simulator,name=iPhone 15,OS=17.5'
xcodebuild test-without-building -scheme Fennec -destination 'platform=iOS Simulator,name=iPhone 15,OS=17.5' -testPlan FullFunctionalTestPlan ARCHS="arm64" -only-testing:XCUITests/ReadingListTests/testMarkAsReadAndUnreadFromReadingList

Failing XCUITests include the following:

        ReadingListTests.testAddToReadingListPrivateMode()
        ReadingListTests.testMarkAsReadAndUnreadFromReadingList()
        ReadingListTests.testMarkAsReadAndUreadFromReaderView()
        ReadingListTests.testOpenSavedForReadingLongPressInNewTab()
        ReadingListTests.testRemoveFromReadingList()
        ReadingListTests.testRemoveFromReadingView()
        ReadingListTests.testRemoveSavedForReadingLongPress()

Expected behavior

The page is shown in reader view.

Actual behavior

💥 The app quits.

Device & build information

ReadingListTests.testMarkAsReadAndUnreadFromReadingList: https://github.com/user-attachments/assets/4af2050e-8f16-43f7-8f7b-39a29d43e7e7

┆Issue is synchronized with this Jira Task

PARAIPAN9 commented 1 week ago

QA Notes: This is primarily for automated testing (where the crash occurred), but it can also be tested manually to ensure the app does not crash anymore when tapping the reader mode button.

dragosb01 commented 1 week ago

The automation tests are passing now.