search

mozilla-mobile / firefox-ios

Firefox for iOS
Mozilla Public License 2.0
12.23k stars 2.94k forks source link

Clean up remote tab management changes #23075

Open lougeniaC64 opened 1 day ago

lougeniaC64 commented 1 day ago

Remove unnecessary self references from RustRemoteTabs and rename the e argument in sendEventToDevice call made in Profile.flushTabCommands per @mattreaganmozilla's request.

Note: The argument renaming will require a breaking appServices change so addressing these changes has been separated from #22799 as to not delay landing those changes.

┆Issue is synchronized with this Jira Task

mattreaganmozilla commented 1 day ago

Note: The argument renaming will require a breaking appServices change so addressing these changes has been separated from https://github.com/mozilla-mobile/firefox-ios/pull/22799 as to not delay landing those changes.

@lougeniaC64 If the change is nontrivial for any reason, I'd say it's fine to close this; the previous PR suggestions were very minor and entirely for readability/stylistic reasons. Definitely not a big deal. Thank you for filing/tracking this, however. 🙏