Bugfix FXIOS-10308 Incorrect connection type is displayed in ETP panel

petruSt24 commented 1 week ago

:scroll: Tickets

:bulb: Description

Found the culprit after trying out switching feature flags, there's no more urlBar if the toolbar refactor is enabled so I switched the check on the current webView's hasOnlySecureContent for this case

:pencil: Checklist

You have to check all boxes before merging

[X] Filled in the above information (tickets numbers and description of your work)
[X] Updated the PR name to follow our PR naming guidelines
[ ] Wrote unit tests and/or ensured the tests suite is passing
[ ] When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
[ ] If needed, I updated documentation / comments for complex code and public methods
[ ] If needed, added a backport comment (example @Mergifyio backport release/v120)

mobiletest-ci-bot commented 1 week ago

	Messages
:book:	Project coverage: 32.28%
:book:	Edited 1 files
:book:	Created 0 files

Client.app: Coverage: 30.17

File	Coverage
BrowserCoordinator.swift	70.87%	✅

Generated by :no_entry_sign: Danger Swift against f7981ddd49c15078d9a7099d12fc964d8c5eeeb6

cyndichin commented 1 week ago

tagging @thatswinnie to confirm since she may have more context in this area + if this conforms to the new toolbar work

mozilla-mobile / firefox-ios