mozilla-mobile / firefox-ios

Firefox for iOS
Mozilla Public License 2.0
12.25k stars 2.94k forks source link

Share sheet doesn’t expand to full height if you tap and hold the sheet before it loads the page’s favicon and title #23178

Open cpeterso opened 1 week ago

cpeterso commented 1 week ago

Steps to reproduce

  1. Load a web page, such as https://www.wikipedia.org/
  2. Tap the toolbar’s Share button ⬆️.
  3. As the share sheet opens at half height, quickly tap and hold the share sheet’s menu items but do not scroll yet!
  4. Without releasing your finger, wait for the share sheet’s header to load the page’s favicon and title.
  5. Then scroll the share sheet.

Expected behavior

The share sheet should expand to full height.

image

Actual behavior

The share sheet scrolls but stays half height, not expanding to full height. The share sheet’s menu items still work correctly; they’re just harder to see.

I can reproduce this bug with the new toolbar’s Share button, the old menu’s Share menu item, and Chrome’s Share button. I can’t reproduce in Safari. I don’t know if this is a bug or race condition in iOS’s share sheet component or an application bug that Firefox and Chrome happened to both implement independently.

This bug is a lot easier to reproduce with the new toolbar because the toolbar’s button (and thus your finger) is so close to the share sheet as it’s still loading.

image

Device & build information

┆Issue is synchronized with this Jira Task