mozilla-mobile / firefox-ios

Firefox for iOS
Mozilla Public License 2.0
12.24k stars 2.94k forks source link

Refactor FXIOS-10581 [Unified Search] - Add a check to isEditing before requesting to close keyboard #23189

Closed PARAIPAN9 closed 3 days ago

PARAIPAN9 commented 4 days ago

:scroll: Tickets

Jira ticket Github issue

:bulb: Description

mobiletest-ci-bot commented 4 days ago
Messages
:book: Project coverage: 32.1%
:book: Edited 1 files
:book: Created 0 files

Client.app: Coverage: 30.86

File Coverage
BrowserCoordinator.swift 70.72%

Generated by :no_entry_sign: Danger Swift against 92a0120a40dbcea0c0c9e6023d2d5ef3f4522efe

PARAIPAN9 commented 3 days ago

Thanks @PARAIPAN9, behaviour looks the same! 🙌

P.S. While I was testing I noticed another funny keyboard issue. But it seems unrelated to your work here so I've filed another bug ticket: https://mozilla-hub.atlassian.net/browse/FXIOS-10598

Haha, non-stop problems with the keyboard. 🤣

ih-codes commented 3 days ago

Thanks @PARAIPAN9, behaviour looks the same! 🙌 P.S. While I was testing I noticed another funny keyboard issue. But it seems unrelated to your work here so I've filed another bug ticket: https://mozilla-hub.atlassian.net/browse/FXIOS-10598

Haha, non-stop problems with the keyboard. 🤣

Hahah no kidding!! Typical iOS development. 🤣