mozilla-mobile / firefox-ios

Firefox for iOS
Mozilla Public License 2.0
12.25k stars 2.94k forks source link

Refactor FXIOS-10467 - Remove force_cast violations from MenuKit and ContentBlockingGenerator #23193

Closed bmihai23 closed 4 days ago

bmihai23 commented 1 week ago

:scroll: Tickets

Jira ticket Github issue

:bulb: Description

:pencil: Checklist

You have to check all boxes before merging

adudenamedruby commented 1 week ago

I'm swamped with some release stuff. Passing to @FilippoZazzeroni for review! :D

bmihai23 commented 4 days ago

🎉 🎉 Thank you again for the contribution, great work

Thank you @FilippoZazzeroni, it means a lot coming from you, I also want to thank you for all the guidance and support you’ve given me throughout the process

mobiletest-ci-bot commented 4 days ago
Messages
:book: Project coverage: 33.26%
:book: Edited 3 files
:book: Created 0 files

MenuKit: Coverage: 39.94

File Coverage
MenuTableView.swift 41.86% ⚠️

Generated by :no_entry_sign: Danger Swift against f43a9f7a0527aa379debc74885e87a703b372c1a

FilippoZazzeroni commented 4 days ago

No problem @bmihai23 😃 it is a pleasure for me. I do really appreciate your commitment and i don't want to be late to respond or either review your PR. Anyway if you have any questions, or want any other issue to work on just feel free to reach out on Element chat you can DM me there.