mozilla-mobile / firefox-ios

Firefox for iOS
Mozilla Public License 2.0
12.24k stars 2.94k forks source link

Add FXIOS-10594 - Add attachments support to RS and pull `tracking-protection-lists-ios` #23199

Closed issammani closed 18 hours ago

issammani commented 3 days ago

:scroll: Tickets

Jira ticket Github issue

:bulb: Description

This PR:

issammani commented 3 days ago

cc @mattreaganmozilla ( and @nbhasin2 ) for the pp session today. I prepared some stuff 😄

mattreaganmozilla commented 3 days ago

@issammani This looks great so far, thanks for taking this on 👏

mobiletest-ci-bot commented 1 day ago
Warnings
:warning: Pull Request size seems relatively large. If this Pull Request contains multiple changes, please split each into separate PR will helps faster, easier review. Consider using epic branches for work that would affect main.
Messages
:book: Project coverage: 33.25%
:book: Edited 5 files
:book: Created 10 files

Client.app: Coverage: 31.36

File Coverage
RemoteSettingsFetchConfig.swift 72.73%

Generated by :no_entry_sign: Danger Swift against 97396da48d0450c58ba924e3c2aecead4d2ba60d

issammani commented 1 day ago

@nbhasin2 I think this is good. The only failing tests are address related which are also failing on main.

nbhasin2 commented 1 day ago

I gave you R+ but are you sure below is right? image

issammani commented 1 day ago

I gave you R+ but are you sure below is right?

Nice catch @nbhasin2. I updated the code in https://github.com/mozilla-mobile/firefox-ios/pull/23199/commits/6e4c6d63fe003836722ec0898c723065659e855f to save the attachments as is from the server.

Before https://github.com/mozilla-mobile/firefox-ios/pull/23199/commits/6e4c6d63fe003836722ec0898c723065659e855f

Screenshot 2024-11-20 at 20 07 37

After https://github.com/mozilla-mobile/firefox-ios/pull/23199/commits/6e4c6d63fe003836722ec0898c723065659e855f

Screenshot 2024-11-20 at 20 08 23

issammani commented 1 day ago

Hey @isabelrios, @dragosb01 is OOO. Can you take a look please ? 😄