Closed issammani closed 18 hours ago
cc @mattreaganmozilla ( and @nbhasin2 ) for the pp session today. I prepared some stuff 😄
@issammani This looks great so far, thanks for taking this on 👏
Warnings | |
---|---|
:warning: | Pull Request size seems relatively large. If this Pull Request contains multiple changes, please split each into separate PR will helps faster, easier review. Consider using epic branches for work that would affect main. |
Messages | |
---|---|
:book: | Project coverage: 33.25% |
:book: | Edited 5 files |
:book: | Created 10 files |
File | Coverage | |
---|---|---|
RemoteSettingsFetchConfig.swift | 72.73% | ✅ |
Generated by :no_entry_sign: Danger Swift against 97396da48d0450c58ba924e3c2aecead4d2ba60d
@nbhasin2 I think this is good. The only failing tests are address related which are also failing on main.
I gave you R+ but are you sure below is right?
I gave you R+ but are you sure below is right?
Nice catch @nbhasin2. I updated the code in https://github.com/mozilla-mobile/firefox-ios/pull/23199/commits/6e4c6d63fe003836722ec0898c723065659e855f to save the attachments as is from the server.
Hey @isabelrios, @dragosb01 is OOO. Can you take a look please ? 😄
:scroll: Tickets
Jira ticket Github issue
:bulb: Description
This PR:
Update_Remote_Settings.py
.tracking-protection-lists-ios
collection to config.fetch_attachments
andsave_records
.tracking-protection-lists-ios
.:pencil: Checklist
You have to check all boxes before merging
@Mergifyio backport release/v120
)