mozilla-mobile / firefox-ios

Firefox for iOS
Mozilla Public License 2.0
12.25k stars 2.94k forks source link

Settings screen: "Learn More" links in Send Usage Feedback & Studies descriptions are not tappable #23205

Open data-sync-user opened 1 week ago

data-sync-user commented 1 week ago

It appears as if the “Learn More” text in both these Settings should navigate somewhere… but they are not tappable, and I see no indication of a link in the code.

The “Learn More” string description for Send Usage data says: title for a link that explains how mozilla collects telemetry")

The “Learn More” string description for Send Usage data says: Title for a link that explains what Mozilla means by Studies

!Screenshot 2024-11-18 at 12.18.13 PM.png|width=33.33333333333333%,alt="Screenshot 2024-11-18 at 12.18.13 PM.png"!

Developer reference:

These NSAttributedString are set in StudiesToggleSetting and SendAnonymousUsageDataSetting.

┆Issue is synchronized with this Jira Bug

data-sync-user commented 1 week ago

➤ Isabella commented:

This was raised in #firefox-ios Andres Furlan . I could probably fix it since my Share Link work is in this area, but I have no idea what the actual links should be for these two Learn More links…

data-sync-user commented 1 week ago

➤ Andres Furlan commented:

Ashley Thomas lets link this one with the ToS project. If we have a quick fix, we will push it sooner.

data-sync-user commented 1 week ago

➤ Isabella commented:

I managed to find a quick fix for this Andres Furlan . In PR here. https://github.com/mozilla-mobile/firefox-ios/pull/23212 ( https://github.com/mozilla-mobile/firefox-ios/pull/23212|smart-link )

Not quite sure what happened to break it, but we have a test in here now to detect it if it happens again!

data-sync-user commented 1 week ago

➤ Andres Furlan commented:

Thanks Isabella !!

data-sync-user commented 1 week ago

➤ Ashley Thomas commented:

Added the labels & Epic for the ToS project. Thanks for tacklign this Isabella !