Bugfix FXIOS-10599 ⁃ [Menu] - Menu functionalities not working

dicarobinho commented 2 days ago

:scroll: Tickets

:bulb: Description

Removed didFinish method call from onViewDismissed callback because if that is happening, self is nil inside the MainMenuCoordinator and navigateTo method will not pass the guard.

:pencil: Checklist

You have to check all boxes before merging

[x] Filled in the above information (tickets numbers and description of your work)
[x] Updated the PR name to follow our PR naming guidelines
[ ] Wrote unit tests and/or ensured the tests suite is passing
[ ] When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
[ ] If needed, I updated documentation / comments for complex code and public methods
[ ] If needed, added a backport comment (example @Mergifyio backport release/v120)

mobiletest-ci-bot commented 2 days ago

	Messages
:book:	Project coverage: 32.86%
:book:	Edited 1 files
:book:	Created 0 files

Client.app: Coverage: 31.12

File	Coverage
BrowserCoordinator.swift	70.09%	✅

Generated by :no_entry_sign: Danger Swift against 34c556332dfd0b74d10b3a790d31a8f270006764

adudenamedruby commented 2 days ago

@Mergifyio backport release/v133

mergify[bot] commented 2 days ago

backport release/v133

✅ Backports have been created

* [#23224 Bugfix FXIOS-10599 ⁃ [Menu] - Menu functionalities not working (backport #23218)](https://github.com/mozilla-mobile/firefox-ios/pull/23224) has been created for branch `release/v133`

mozilla-mobile / firefox-ios