mozilla-mobile / firefox-ios

Firefox for iOS
Mozilla Public License 2.0
12.24k stars 2.94k forks source link

Bugfix FXIOS-10602 - [Toolbar Redesign] When long pressing the suggestions that are added in the location view, the keyboard should not show up (backport #23223) #23227

Closed mergify[bot] closed 2 days ago

mergify[bot] commented 2 days ago

:scroll: Tickets

Jira ticket Github issue

:bulb: Description

Video

https://github.com/user-attachments/assets/f9e0eea5-6f3a-4795-aade-aff047157724

:pencil: Checklist

You have to check all boxes before merging


This is an automatic backport of pull request #23223 done by Mergify.

mergify[bot] commented 2 days ago

Cherry-pick of 507358ee1027b4a76b87d8ca1a65ab44ebc61878 has failed:

On branch mergify/bp/release/v133/pr-23223
Your branch is up to date with 'origin/release/v133'.

You are currently cherry-picking commit 507358ee1.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
    both modified:   firefox-ios/Client/Frontend/Browser/Toolbars/Redux/AddressBarState.swift
    deleted by us:   firefox-ios/firefox-ios-tests/Tests/ClientTests/Toolbar/AddressBarStateTests.swift

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

PARAIPAN9 commented 2 days ago

Closing it, I can't backport it, it depends on other changes that are in main and not backported for v133. For example the shouldShowKeyboard property does not even exist on v133.