Bugfix FXIOS-10604 ⁃ For cases when we don't have a baseDomain, add a default string

dicarobinho commented 2 days ago

:scroll: Tickets

Added a default value for websites that don't ahave a base domain

You have to check all boxes before merging

[x] Filled in the above information (tickets numbers and description of your work)
[x] Updated the PR name to follow our PR naming guidelines
[ ] Wrote unit tests and/or ensured the tests suite is passing
[ ] When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
[ ] If needed, I updated documentation / comments for complex code and public methods
[ ] If needed, added a backport comment (example @Mergifyio backport release/v120)

mobiletest-ci-bot commented 2 days ago

File	Coverage
BrowserViewController+WebViewDelegates.swift	4.46%	⚠️

Generated by :no_entry_sign: Danger Swift against 975a67844cecce115dc98ca35e716440dbaa1cd3

flodolo commented 1 day ago

This type of replacement is error-prone when it comes to localization, because the sentence's structure might need to change.

Can we use a separate string instead?

This site is asking to download a file and add an event to your calendar.