Closed lmarceau closed 1 day ago
Warnings | |
---|---|
:warning: | Pull Request size seems relatively large. If this Pull Request contains multiple changes, please split each into separate PR will helps faster, easier review. Consider using epic branches for work that would affect main. |
Messages | |
---|---|
:book: | Project coverage: 32.5% |
:book: | Edited 4 files |
:book: | Created 0 files |
File | Coverage | |
---|---|---|
TopTabsViewController.swift | 0.0% | ⚠️ |
LegacyInactiveTabViewModel.swift | 0.0% | ⚠️ |
TabDisplayManager.swift | 0.0% | ⚠️ |
Generated by :no_entry_sign: Danger Swift against cc7dac42e90b3eacb5bc1e50f3c3f9af9a0cd493
:scroll: Tickets
Jira ticket Github issue
:bulb: Description
Removing some part of the Legacy inactive tab code. Still some related code to be removed, this is one step in that direction before I get to the most tangled part.
Realized by looking in this code that we haven't move the legacy inactive tab telemetry to the new code base it seems. So events like
inactiveTabSwipeClose
,inactiveTabShown
,inactiveTabCloseAllButton
andopenInactiveTab
amongst other things aren't used anymore. I asked Andy if we want to migrate those, if so I'll create a task for this so we implement them back (otherwise I'll delete them).:pencil: Checklist
You have to check all boxes before merging
@Mergifyio backport release/v120
)