Bugfix FXIOS-10335 Fix audio/video leak after closing tab (backport #23213)

mergify[bot] commented 2 days ago

:scroll: Tickets

:bulb: Description

⚠️ For additional notes please see the linked Jira. This is a quick initial fix. I'm hoping to get extra eyes and regression testing on this. We are also still leaking a Tab object however I believe we can live with that if needed for v133, the critical leak is the WKWebView which causes audio/video for closed tabs to continue playing.

:pencil: Checklist

You have to check all boxes before merging

[x] Filled in the above information (tickets numbers and description of your work)
[x] Updated the PR name to follow our PR naming guidelines
[ ] Wrote unit tests and/or ensured the tests suite is passing
[ ] When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
[ ] If needed, I updated documentation / comments for complex code and public methods
[ ] If needed, added a backport comment (example @Mergifyio backport release/v120)

This is an automatic backport of pull request #23213 done by Mergify.

mattreaganmozilla commented 2 days ago

cc @DonalMe

mobiletest-ci-bot commented 2 days ago

	Messages
:book:	Project coverage: 31.9%
:book:	Edited 1 files
:book:	Created 0 files

Client.app: Coverage: 30.67

File	Coverage
BrowserViewController.swift	4.66%	⚠️

Generated by :no_entry_sign: Danger Swift against 02f79f4ef7905681de70e7108a753dc8ed6e8bab

mozilla-mobile / firefox-ios