mozilla-mobile / firefox-ios

Firefox for iOS
Mozilla Public License 2.0
12.24k stars 2.94k forks source link

Add FXIOS-10460 [Homepage] Context Menu Navigation #23246

Closed cyndichin closed 1 day ago

cyndichin commented 2 days ago

:scroll: Tickets

Jira ticket Github issue

:bulb: Description

Add navigation foundation to show the context menu / photon action sheet.

Next PRs (after PTO) will include specific actions for pocket and top sites. Tests will be added for the context menu state, UI tests will be added at a later date to test the navigation.

:pencil: Checklist

You have to check all boxes before merging

Screenshots

https://github.com/user-attachments/assets/7696d708-5e8d-422c-9fd4-fd33d0ef76f1

cyndichin commented 2 days ago

@tusharC95 , @DanielDervishi , @Cramsden for visibility

mobiletest-ci-bot commented 1 day ago
Messages
:book: Project coverage: 32.32%
:book: Edited 9 files
:book: Created 1 files

Client.app: Coverage: 31.12

File Coverage
BrowserViewController.swift 4.74% ⚠️
BrowserCoordinator.swift 69.37%
BrowserNavigationHandler.swift 76.92%
ContextMenuState.swift 0.0% ⚠️
BrowserViewControllerState.swift 47.7% ⚠️
NavigationBrowserAction.swift 100.0%
HomepageViewController.swift 35.73% ⚠️
BrowserNavigationType.swift 100.0%

Generated by :no_entry_sign: Danger Swift against 8a92232c760cfcd7c024997729ef1e5817dc7ccc

cyndichin commented 1 day ago

If no changes needed, feel free to approve + merge this PR. Otherwise, will address any changes when I return.