Closed cyndichin closed 1 day ago
@tusharC95 , @DanielDervishi , @Cramsden for visibility
Messages | |
---|---|
:book: | Project coverage: 32.32% |
:book: | Edited 9 files |
:book: | Created 1 files |
File | Coverage | |
---|---|---|
BrowserViewController.swift | 4.74% | ⚠️ |
BrowserCoordinator.swift | 69.37% | ✅ |
BrowserNavigationHandler.swift | 76.92% | ✅ |
ContextMenuState.swift | 0.0% | ⚠️ |
BrowserViewControllerState.swift | 47.7% | ⚠️ |
NavigationBrowserAction.swift | 100.0% | ✅ |
HomepageViewController.swift | 35.73% | ⚠️ |
BrowserNavigationType.swift | 100.0% | ✅ |
Generated by :no_entry_sign: Danger Swift against 8a92232c760cfcd7c024997729ef1e5817dc7ccc
If no changes needed, feel free to approve + merge this PR. Otherwise, will address any changes when I return.
:scroll: Tickets
Jira ticket Github issue
:bulb: Description
Add navigation foundation to show the context menu / photon action sheet.
showContextMenu
this will create theContextMenuState
which will be use to populate the viewModel used for thePhotonActionSheet
viewContextMenuState
which will hold action logic.Next PRs (after PTO) will include specific actions for pocket and top sites. Tests will be added for the context menu state, UI tests will be added at a later date to test the navigation.
:pencil: Checklist
You have to check all boxes before merging
@Mergifyio backport release/v120
)Screenshots
https://github.com/user-attachments/assets/7696d708-5e8d-422c-9fd4-fd33d0ef76f1