Refactor - auto update credential provider script

mozilla-mobile / firefox-ios

Firefox for iOS

Mozilla Public License 2.0

12.24k stars 2.94k forks source link

Refactor - auto update credential provider script #23248

Closed github-actions[bot] closed 13 hours ago

github-actions[bot] commented 2 days ago

Automated changes by create-pull-request GitHub action

mobiletest-ci-bot commented 2 days ago

	Messages
:book:	Edited 5 files
:book:	Created 0 files

Generated by :no_entry_sign: Danger Swift against 1e3a64fc120358a357ac156e09d185fded1614d1

isabelrios commented 2 days ago

@issammani There might be something that needs to be updated either with the PR or the UI tests, there are 4 failing consistently related to credit card and addresses:

testDeleteAddress
testUpdateAllAddressFields
testAddNewAddressAllFieldsFilled
testAutofillCreditCardsToggleOnOff

issammani commented 1 day ago

@issammani There might be something that needs to be updated either with the PR or the UI tests, there are 4 failing consistently related to credit card and addresses:
* testDeleteAddress

* testUpdateAllAddressFields

* testAddNewAddressAllFieldsFilled

* testAutofillCreditCardsToggleOnOff

Thanks @isabelrios. I agree something seems off with this. Taking a look now 😄

issammani commented 21 hours ago

Ok I think I know what's happening. Fix incoming 😄

issammani commented 13 hours ago

Fix currently landing in central. Will close this. We will probably get a green version tomorrow.