Bugfix FXIOS-10584 - [Toolbar Redesign] 20+ new homepage tabs are opened when I try to open just one new tab

PARAIPAN9 commented 4 days ago

:scroll: Tickets

Jira ticket Github issue

:bulb: Description

After investigating, I've found out that the bug was caused by this PR that fixed FXIOS-10500. I'm not really 100% sure what was happening but we are dealing with references here and some kind of retain cycle was certainly occuring because after tapping the + (add new tab button) intermittently, 3, 4(a random number) of redux actions for opening a new tab were triggered.
While trying to find the cause of this bug, I found an even bigger memory leak for Toolbar Buttons that were never deallocated because self was captured in the action handler.
Reverting the change from the PR mentioned above and fixing the leak seemed to solve both problems. FXIOS-10500 and the one addressed in this PR.

Video

https://github.com/user-attachments/assets/3c211123-d9e4-4a2e-b89f-03754044e707

:pencil: Checklist

You have to check all boxes before merging

[x] Filled in the above information (tickets numbers and description of your work)
[x] Updated the PR name to follow our PR naming guidelines
[ ] Wrote unit tests and/or ensured the tests suite is passing
[ ] When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
[ ] If needed, I updated documentation / comments for complex code and public methods
[ ] If needed, added a backport comment (example @Mergifyio backport release/v120)

mobiletest-ci-bot commented 4 days ago

	Messages
:book:	Edited 2 files
:book:	Created 0 files

Generated by :no_entry_sign: Danger Swift against e902c435cf49a689fe078a8070a26dc66efd5b22

PARAIPAN9 commented 4 days ago

@Mergifyio backport release/v133

mergify[bot] commented 4 days ago

backport release/v133

✅ Backports have been created

* [#23258 Bugfix FXIOS-10584 - [Toolbar Redesign] 20+ new homepage tabs are opened when I try to open just one new tab (backport #23253)](https://github.com/mozilla-mobile/firefox-ios/pull/23258) has been created for branch `release/v133`

mattreaganmozilla commented 2 days ago

Nice work on this @PARAIPAN9 👍

PARAIPAN9 commented 2 days ago

Thanks @mattreaganmozilla, I appreciate it!!

mozilla-mobile / firefox-ios