Closed mergify[bot] closed 4 days ago
Messages | |
---|---|
:book: | Project coverage: 32.65% |
:book: | Edited 2 files |
:book: | Created 0 files |
File | Coverage | |
---|---|---|
ToolbarButton.swift | 0.0% | ⚠️ |
BrowserAddressToolbar.swift | 0.0% | ⚠️ |
Generated by :no_entry_sign: Danger Swift against 2631c9dd47c829ec13727e56bb8710273c08d7e8
:scroll: Tickets
Jira ticket Github issue
:bulb: Description
After investigating, I've found out that the bug was caused by this PR that fixed FXIOS-10500. I'm not really 100% sure what was happening but we are dealing with references here and some kind of retain cycle was certainly occuring because after tapping the
+
(add new tab button) intermittently, 3, 4(a random number) of redux actions for opening a new tab were triggered.While trying to find the cause of this bug, I found an even bigger memory leak for Toolbar Buttons that were never deallocated because
self
was captured in the action handler.Reverting the change from the PR mentioned above and fixing the leak seemed to solve both problems. FXIOS-10500 and the one addressed in this PR.
Video
https://github.com/user-attachments/assets/3c211123-d9e4-4a2e-b89f-03754044e707
:pencil: Checklist
You have to check all boxes before merging
@Mergifyio backport release/v120
)FXIOS-10500: https://mozilla-hub.atlassian.net/browse/FXIOS-10500?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
This is an automatic backport of pull request #23253 done by Mergify.