mozilla-mobile / firefox-ios

Firefox for iOS
Mozilla Public License 2.0
12.24k stars 2.94k forks source link

Bugfix FXIOS-10574 Protection panel tweaks Design QA #23263

Open petruSt24 opened 1 day ago

petruSt24 commented 1 day ago

:scroll: Tickets

Jira ticket Github issue

:bulb: Description

Updated the design of the protection panel based on the feedback from design

:pencil: Checklist

You have to check all boxes before merging

petruSt24 commented 9 hours ago

Simulator Screenshot - iPhone 15 - 2024-11-21 at 21 00 32 @MattLichtenstein thank you for the suggestions, I replaced the stackView with a UIView to fix the spacing issue and updated the margin for the settings link button, but the website title is not bolded and it uses the menu navigation bar, they should look the same

MattLichtenstein commented 4 hours ago

@petruSt24 it looks like we are changing the font of the HeaderView title from body to headline in HeaderView::setupDetails. Seems like this, and the corner radius of the favicon are artifacts of the old tracking protection panel and seem to need updating