mozilla-mobile / firefox-ios

Firefox for iOS
Mozilla Public License 2.0
12.24k stars 2.94k forks source link

Fix FXIOS-10626 - Use separate string for sites without a domain in calendar alert #23266

Closed issammani closed 1 day ago

issammani commented 1 day ago

:scroll: Tickets

Jira ticket Github issue

:bulb: Description

This PR:

For context see: https://github.com/mozilla-mobile/firefox-ios/pull/23232#issuecomment-2488960898

:pencil: Checklist

You have to check all boxes before merging

mobiletest-ci-bot commented 1 day ago
Messages
:book: Project coverage: 33.04%
:book: Edited 2 files
:book: Created 0 files

Client.app: Coverage: 31.13

File Coverage
BrowserViewController+WebViewDelegates.swift 4.44% ⚠️

Generated by :no_entry_sign: Danger Swift against cd598ad43a62d2ae7beea88cc77fc80203cf9d66

issammani commented 1 day ago

Merging since generic BR is green and the only failing tests are testUpdateAllAddressFields() and testAddNewAddressAllFieldsFilled() which are also failing on main.