Add FXIOS-10609 [Native Error Page] Added flag to show no internet connection error page only

tusharC95 commented 1 day ago

:scroll: Tickets

Added no_internet_connection_error in nativeErrorPageFeature.yaml. This parameter is exclusively to show/hide new "no internet connection" error page.
Additionally added a check for no internet connection error code.
Added default strings for error page.

You have to check all boxes before merging

[x] Filled in the above information (tickets numbers and description of your work)
[x] Updated the PR name to follow our PR naming guidelines
[ ] Wrote unit tests and/or ensured the tests suite is passing
[ ] When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
[ ] If needed, I updated documentation / comments for complex code and public methods
[ ] If needed, added a backport comment (example @Mergifyio backport release/v120)

mobiletest-ci-bot commented 1 day ago

File	Coverage
ErrorPageHelper.swift	0.0%	⚠️
BrowserViewController.swift	4.73%	⚠️
FeatureFlagsDebugViewController.swift	0.0%	⚠️
NativeErrorPageViewController.swift	88.46%	✅
BrowserViewController+WebViewDelegates.swift	4.34%	⚠️
NimbusFlaggableFeature.swift	97.76%	✅
NimbusFeatureFlagLayer.swift	64.45%	✅
NativeErrorPageHelper.swift	0.0%	⚠️

Generated by :no_entry_sign: Danger Swift against a01ad40f976a4a2c67f0ea9d2ccc9149674ac947

tusharC95 commented 13 hours ago

Thank you for the thorough testing 🫡. This issue could be linked to https://github.com/mozilla-mobile/firefox-ios/pull/23269. specifically BrowserViewType.nativeErrorPage. I will try to repro the bug and fix it asap.