Closed lmarceau closed 13 hours ago
Messages | |
---|---|
:book: | Project coverage: 33.63% |
:book: | Edited 10 files |
:book: | Created 0 files |
File | Coverage | |
---|---|---|
TopTabsViewController.swift | 0.0% | ⚠️ |
AppSessionManager.swift | 100.0% | ✅ |
TabDisplayManager.swift | 0.0% | ⚠️ |
TabManager.swift | 62.5% | ✅ |
ToggleInactiveTabs.swift | 0.0% | ⚠️ |
LegacyTabManager.swift | 35.34% | ⚠️ |
Generated by :no_entry_sign: Danger Swift against e944f4d27f4310fa6d0351c9179d8dd0b04f542a
:scroll: Tickets
Jira ticket Github issue
:bulb: Description
Remove remaining legacy inactive tab code. This part was a little more tangled up with small things here and there:
AppSessionProvider
didn't needtabUpdateState
anymore as this related only to the legacy Inactive Tabs featureLegacyTabDisplayManager
as this class is only used now for top tabs. This meansTabDisplayType.TabGrid
can be removed as onlyTabDisplayType.TopTabTray
will ever be used in the application.I will do a follow up PR to rename
LegacyTabDisplayManager
toTopTabDisplayManager
for clarity I think.:pencil: Checklist
You have to check all boxes before merging
@Mergifyio backport release/v120
)