mozilla-mobile / firefox-ios

Firefox for iOS
Mozilla Public License 2.0
12.24k stars 2.94k forks source link

dismiss search bar when tap on the outside view in HistoryPanel #23276

Open gokulvenkat243 opened 19 hours ago

gokulvenkat243 commented 19 hours ago

:scroll: Tickets

Jira ticket Github issue

:bulb: Description

:pencil: Checklist

You have to check all boxes before merging

ih-codes commented 8 hours ago

Hi @gokulvenkat243! Thank you for your contribution. 🙏

I took a quick look at your PR. Your code does helpfully close the HistoryPanel's search bar, but I think we should also account for closing the keyboard with this solution (see video below for the problem).

You can try calling searchbar.resignFirstResponder() instead of calling it on the bottomStackView. You can test in the simulator by making sure you have the software keyboard enabled.

https://github.com/user-attachments/assets/3d46d8fe-61d9-4f79-bba0-ebaac498fb3d