mozilla-mobile / firefox-ios

Firefox for iOS
Mozilla Public License 2.0
12.24k stars 2.94k forks source link

Add FXIOS-10603 Telemetry for pull refresh easter egg (backport #23252) #23277

Open mergify[bot] opened 19 hours ago

mergify[bot] commented 19 hours ago

:scroll: Tickets

Jira ticket Github issue

:bulb: Description

Add Telemetry for pull refresh easter egg and change pull refresh telemetry to event type.

:pencil: Checklist

You have to check all boxes before merging

mergify[bot] commented 19 hours ago

Cherry-pick of a47b61cf870583e5e46c1648958e7b79fc566522 has failed:

On branch mergify/bp/release/v133/pr-23252
Your branch is up to date with 'origin/release/v133'.

You are currently cherry-picking commit a47b61cf8.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
    modified:   firefox-ios/Client/Telemetry/TelemetryWrapper.swift
    modified:   firefox-ios/Client/metrics.yaml

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
    deleted by us:   firefox-ios/Client/Frontend/Browser/WebView/PullRefreshView.swift

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

mobiletest-ci-bot commented 19 hours ago
Messages
:book: Project coverage: 32.65%
:book: Edited 2 files
:book: Created 1 files

Client.app: Coverage: 30.67

File Coverage
TelemetryWrapper.swift 71.47%

Generated by :no_entry_sign: Danger Swift against 4041a6d29fa5f99f817638942778bb82caba3ab7

FilippoZazzeroni commented 19 hours ago

This should be merged in case PullRefresh gets merged Pull refresh PR