Open lmarceau opened 9 hours ago
Messages | |
---|---|
:book: | Project coverage: 33.24% |
:book: | Edited 7 files |
:book: | Created 1 files |
File | Coverage | |
---|---|---|
TabDisplayView.swift | 39.39% | ⚠️ |
TabManagerMiddleware.swift | 14.59% | ⚠️ |
TabsPanelState.swift | 92.77% | ✅ |
TabPanelAction.swift | 100.0% | ✅ |
InactiveTabsTelemetry.swift | 0.0% | ⚠️ |
TabDisplayManager.swift | 0.0% | ⚠️ |
TelemetryWrapper.swift | 70.88% | ✅ |
Generated by :no_entry_sign: Danger Swift against ab4573c0609a86185961d1d3383b455d2a99b7c0
:scroll: Tickets
Jira ticket Github issue
:bulb: Description
Inactive tab telemetry isn't sent anymore, so this branch is currently aiming to enable this back. This is a work in progress as I'm not sure of a bunch of things. I think I figured out telemetry
inactiveTabSwipeClose
andinactiveTabsCloseAllBtn
as they are in the middleware, but not sure about the others. I added some comments in code so we can discuss!The Glean telemetry that needs to be added back is:
inactiveTabShown
when the inactive tab section is shown to the user.inactiveTabSwipeClose
when the swipe to close an inactive tab is used.inactiveTabsCloseAllBtn
when the close all inactive tabs button is used.openInactiveTab
when the inactive tab cell is clicked and the tab is opened in the browser.toggleInactiveTabTray
when the inactive tab view is either expanded or collapsed.:pencil: Checklist
You have to check all boxes before merging
@Mergifyio backport release/v120
)