mozilla-mobile / firefox-ios

Firefox for iOS
Mozilla Public License 2.0
12.24k stars 2.94k forks source link

Add FXIOS-10639 #23286 Inactive tab telemetry back into tab tray #23296

Open lmarceau opened 9 hours ago

lmarceau commented 9 hours ago

:scroll: Tickets

Jira ticket Github issue

:bulb: Description

Inactive tab telemetry isn't sent anymore, so this branch is currently aiming to enable this back. This is a work in progress as I'm not sure of a bunch of things. I think I figured out telemetry inactiveTabSwipeClose and inactiveTabsCloseAllBtn as they are in the middleware, but not sure about the others. I added some comments in code so we can discuss!

The Glean telemetry that needs to be added back is:

  1. inactiveTabShown when the inactive tab section is shown to the user.
  2. inactiveTabSwipeClose when the swipe to close an inactive tab is used.
  3. inactiveTabsCloseAllBtn when the close all inactive tabs button is used.
  4. openInactiveTab when the inactive tab cell is clicked and the tab is opened in the browser.
  5. toggleInactiveTabTray when the inactive tab view is either expanded or collapsed.

:pencil: Checklist

You have to check all boxes before merging

mobiletest-ci-bot commented 9 hours ago
Messages
:book: Project coverage: 33.24%
:book: Edited 7 files
:book: Created 1 files

Client.app: Coverage: 31.35

File Coverage
TabDisplayView.swift 39.39% ⚠️
TabManagerMiddleware.swift 14.59% ⚠️
TabsPanelState.swift 92.77%
TabPanelAction.swift 100.0%
InactiveTabsTelemetry.swift 0.0% ⚠️
TabDisplayManager.swift 0.0% ⚠️
TelemetryWrapper.swift 70.88%

Generated by :no_entry_sign: Danger Swift against ab4573c0609a86185961d1d3383b455d2a99b7c0