mozilla-mobile / firefox-ios

Firefox for iOS
Mozilla Public License 2.0
12.24k stars 2.94k forks source link

Bugfix FXIOS-10646 Ensure we do not change Menu > Share behaviour to Messages #23301

Open ih-codes opened 7 hours ago

ih-codes commented 7 hours ago

:scroll: Tickets

Jira ticket Github issue

:bulb: Description

This PR partially reverts a change to sharing to accommodate the Info Card Referral project. This change avoids appending website titles to any link shared from the app (specifically to Messages for feature parity with Safari).

Demo

Before

Undesired behaviour when sharing a website URL from Menu > Share:

After

Desired behaviour when sharing a website URL from Menu > Share:

:pencil: Checklist

You have to check all boxes before merging

mobiletest-ci-bot commented 7 hours ago
Messages
:book: Project coverage: 33.2%
:book: Edited 1 files
:book: Created 0 files

Client.app: Coverage: 31.31

File Coverage
ShareExtensionCoordinator.swift 32.92% ⚠️

Generated by :no_entry_sign: Danger Swift against f0c44f7a8512a0c35d90e5537ca46bb7f997e089